-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diagnostics workers - fix GTL and toolbar #3181
Conversation
wip - loose ends in c9674ee, seems like there's some method to do something on this screen in js, just used in a way that doesn't work? |
with the new gtl, we don't need to reload the whole screen on selection thus, the "can only restart 1 worker at a time" logic must move to JS (at least until we start supporting restarting multiple workers)
…orker_id], drop that this removes `@sb[:selected_worker_id]` completely, in favor of using `checked_or_params` to get the selected worker
the method was called by the old gtl (`gtl/_list`) on row selection, new GTL uses the standard checked_or_params way
before, `pm_get_workers` would reset `@sb[:selected_worker_id]` and call `get_workers` nothing else calls `get_workers` directly, and the id is no longer used merging into 1 method :)
looks like defaulting to current controller on nil, etc. should happen there, not in JS
false means clicking the entry will do nothing this is achieved by setting showUrl to false, ReportDataController#onItemClicked already does nothing when showUrl is false
when `initObject.showUrl` is "", the defaults from initComponent kick in but the logic in onItemClicked ignores clicks when showUrl is falsy so.. logically, false is the right value except there's already code which assumes showUrl is always a string - adding explicit checks
Checked commits https://github.com/himdel/manageiq-ui-classic/compare/e16c2c0051222d3a7e896aeff795264da5868661~...fc5fd8234e920c57021d7719878201339cff6739 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 app/helpers/application_helper/toolbar/diagnostics_server_center.rb
|
Cc @dclarizio |
Diagnostics workers - fix GTL and toolbar (cherry picked from commit 6ac8672) https://bugzilla.redhat.com/show_bug.cgi?id=1533548
Gaprindashvili backport details:
|
Ops > Diagnostics, Server detail, Workers tab
In fine, the screen was a list where clicking an item would simply select the item (unselecting any other), without changing to a detail screen.
Now, we have a checkbox with each item, but clicking the item causes an exception (and the toolbar button to restart the worker doesn't work).
This PR:
onwhen
logic for disabled:clickable
, setting to false causes clicking on items to do nothinghttps://bugzilla.redhat.com/show_bug.cgi?id=1531524